spmallette commented on a change in pull request #1515:
URL: https://github.com/apache/tinkerpop/pull/1515#discussion_r765788782
##########
File path:
gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py
##########
@@ -48,21 +67,25 @@ def __init__(self, url, traversal_source = "g",
protocol_factory=None,
password=password,
kerberized_service=kerberized_service,
headers=headers,
+ session=session,
**transport_kwargs)
self._url = self._client._url
self._traversal_source = self._client._traversal_source
def close(self):
+ logging.info("closing DriverRemoteConnection with url '%s'",
str(self._url))
self._client.close()
def submit(self, bytecode):
+ logging.debug("submit with bytecode '%s'", str(bytecode))
result_set = self._client.submit(bytecode,
request_options=self._extract_request_options(bytecode))
results = result_set.all().result()
return RemoteTraversal(iter(results))
- def submitAsync(self, bytecode):
+ def submit_async(self, bytecode):
Review comment:
i asked you to keep the old `submitAsync` form in `Client` as it was a
breaking change. not sure that it matter so much here because I don't think
anyone calls this directly. maybe just to be safe, retain the old form in
addition to the new and we'll remove the old on merge to `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
