spmallette commented on a change in pull request #1515:
URL: https://github.com/apache/tinkerpop/pull/1515#discussion_r765774083
##########
File path: gremlin-python/src/main/python/gremlin_python/driver/client.py
##########
@@ -129,24 +123,28 @@ def _get_connection(self):
headers=self._headers)
def submit(self, message, bindings=None, request_options=None):
- return self.submitAsync(message, bindings=bindings,
request_options=request_options).result()
+ return self.submit_async(message, bindings=bindings,
request_options=request_options).result()
- def submitAsync(self, message, bindings=None, request_options=None):
Review comment:
I think that renaming this is good but it is a breaking change for
users. let's deprecate `submitAsync` for `submit_async` and have both with the
old function just calling the new one. When merged to master, i will delete the
`submitAsync` one.
note that we do use `warnings` (at least in one place) for deprecation:
```python
warnings.warn(
"As of release 3.3.5, replaced by the
gremlin_python.process.anonymous_traversal.traversal() function.",
DeprecationWarning)
```
I suppose a code comment would suffice as well if you think the warning
thing is too heavy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
