spmallette commented on a change in pull request #1515:
URL: https://github.com/apache/tinkerpop/pull/1515#discussion_r765777877
##########
File path:
gremlin-python/src/main/python/gremlin_python/driver/aiohttp/transport.py
##########
@@ -16,12 +16,11 @@
# specific language governing permissions and limitations
# under the License.
#
-
-
import aiohttp
import asyncio
import async_timeout
from aiohttp import ClientResponseError
+import logging
Review comment:
It's cool that we have logging now. This is going to be a huge help.
Elsewhere I'd commented that we use:
https://docs.python.org/3/library/warnings.html
in one place: `graph.py`. I believe there is a way to re-route warnings to
the logger:
https://docs.python.org/3/library/logging.html#logging.captureWarnings
perhaps we should do that if you haven't already somewhere? or perhaps we
don't need `warnings` anymore at all? or perhaps we should double down on
usage? I'll leave it to you to make a choice on how to rectify `warnings` and
`logging` but i think it would be good to have a strategy here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
