krlawrence commented on a change in pull request #1515:
URL: https://github.com/apache/tinkerpop/pull/1515#discussion_r765871750
##########
File path: gremlin-python/src/main/python/gremlin_python/driver/client.py
##########
@@ -129,24 +123,28 @@ def _get_connection(self):
headers=self._headers)
def submit(self, message, bindings=None, request_options=None):
- return self.submitAsync(message, bindings=bindings,
request_options=request_options).result()
+ return self.submit_async(message, bindings=bindings,
request_options=request_options).result()
- def submitAsync(self, message, bindings=None, request_options=None):
Review comment:
I like the idea of warnings, especially when we will be changing code
that has been this way for ages and is in production all over the place. I
would prefer we keep both for a while rather than remove the old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
