spmallette commented on a change in pull request #1515:
URL: https://github.com/apache/tinkerpop/pull/1515#discussion_r765763491
##########
File path: gremlin-python/src/main/python/gremlin_python/driver/client.py
##########
@@ -107,20 +109,12 @@ def _fill_pool(self):
self._pool.put_nowait(conn)
def close(self):
- if self._sessionEnabled:
- self._close_session()
+ logging.info("Closing Client with url '%s'", self._url)
while not self._pool.empty():
conn = self._pool.get(True)
conn.close()
self._executor.shutdown()
- def _close_session(self):
Review comment:
You removed this little function and I didn't see it's behavior anywhere
else. That effectively undoes the work of #1510 - could you please make sure
the "close" message gets sent when a session is closed just prior to closing
the websocket connection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
