On Tue, 19 Aug 2025 20:07:10 GMT, Alexander Matveev <almat...@openjdk.org>
wrote:
> - Added following note for `--app-content` on macOS to help and man page:
> `The value should be a directory with the "Resources" subdirectory (or any
> other directory that is valid in the "Contents" directory of the application
> bundle). Otherwise, jpackage may produce invalid application bundle which may
> fail code signing and/or notarization.`
> - Added warning if `--app-content` if it points to non-standard subdirectory
> in "Contents" directory.
> - Added test to cover warning message.
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacApplicationBuilder.java
line 134:
> 132: .anyMatch(subDir ->
> contentDir.getFileName().toString()
> 133:
> .equalsIgnoreCase(subDir))) {
> 134: Log.info(MessageFormat.format(I18N.getString(
Can be simplified down to:
Log.info(I18N.format("warning.non.standard.contents.sub.dir", contentDir));
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties
line 88:
> 86: warning.unsigned.app.image=Warning: Using unsigned app-image to build
> signed {0}.
> 87: warning.per.user.app.image.signed=Warning: Support for per-user
> configuration of the installed application will not be supported due to
> missing "{0}" in predefined signed application image.
> 88: warning.non.standard.contents.sub.dir=Warning: --app-content value "{0}"
> points to the non-standard subdirectory in the "Contents" directory of the
> application bundle.
This warning is not particularly helpful. It doesn't provide details.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26848#discussion_r2286330418
PR Review Comment: https://git.openjdk.org/jdk/pull/26848#discussion_r2286334217
