On Tue, 19 Aug 2025 21:05:53 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8356218: [macos] Document --app-content [v3]
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties
> line 88:
>
>> 86: warning.unsigned.app.image=Warning: Using unsigned app-image to build
>> signed {0}.
>> 87: warning.per.user.app.image.signed=Warning: Support for per-user
>> configuration of the installed application will not be supported due to
>> missing "{0}" in predefined signed application image.
>> 88: warning.non.standard.contents.sub.dir=Warning: --app-content value "{0}"
>> points to the non-standard subdirectory in the "Contents" directory of the
>> application bundle.
>
> This warning is not particularly helpful:
> - It doesn't provide details;
> - It is misleading. The value of the `--app-content` cli option specifies
> directories and files that will be copied into the application bundle, not
> those in the bundle.
>
> I'd issue a warning for every unexpected directory/file found in the value of
> the `--app-content` option.
>
> I suggest we have two warning messages:
>
> Warning: The file name of the directory "{0}" specified for the --app-content
> option is not a standard subdirectory name in the "Contents" directory of the
> application bundle. The result application bundle may fail notarization.
>
>
>
> Warning: The value "{0}" of the --app-content option is not a directory. The
> result application bundle may fail notarization.
Updated as suggested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26848#discussion_r2289566184
