On Wed, 20 Aug 2025 01:19:16 GMT, Francesco Andreuzzi <d...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8356218: [macos] Document --app-content [v2]
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacApplicationBuilder.java
> line 130:
>
>> 128: private static void validateAppContentDirs(Application app) {
>> 129: for (var contentDir : app.contentDirs()) {
>> 130: if (!CONTENTS_SUB_DIRS.stream()
>
> You could replace `CONTENTS_SUB_DIRS` with a `Set<String>`, and the
> inspection with
> `CONTENTS_SUB_DIRS.contains(contentDir.getFileName().toString())`.
Updated as suggested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26848#discussion_r2289566359
