On Tue, 19 Aug 2025 21:17:37 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> - Added following note for `--app-content` on macOS to help and man page:
>> `The value should be a directory with the "Resources" subdirectory (or any
>> other directory that is valid in the "Contents" directory of the application
>> bundle). Otherwise, jpackage may produce invalid application bundle which
>> may fail code signing and/or notarization.`
>> - Added warning if `--app-content` if it points to non-standard subdirectory
>> in "Contents" directory.
>> - Added test to cover warning message.
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacApplicationBuilder.java
> line 133:
>
>> 131: if (!CONTENTS_SUB_DIRS.stream()
>> 132: .anyMatch(subDir ->
>> contentDir.getFileName().toString()
>> 133:
>> .equalsIgnoreCase(subDir))) {
>
> Why case-insensitive path name comparison on Unix?
By default macOS is case-insensitive. If I rename `MacOS` to `macos` in
application bundle, such bundle will still works. I assumed that `Resources`
and `resources` are same thing. After thinking more about it I think it should
be case sensitive comparison. Will change it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26848#discussion_r2286373060
