David Brownell <[email protected]> writes: > On Sunday 25 January 2009, David Brownell wrote: >> static void __clk_disable(struct clk *clk) >> { >> - if (clk->usecount) >> - return; >> - >> - davinci_psc_config(DAVINCI_GPSC_ARMDOMAIN, clk->lpsc, 0); >> + BUG_ON(clk->usecount == 0); > > Nitpicking my tweaks: that should be > > if (WARN_ON(clk->usecount == 0)) > return; > > Because if there's a way to continue running ("return" here), > then BUG() variants are the wrong answer. :)
Sounds good, I should s/BUG/WARN/ some of the stuff I've added too. Will do in next version (just posted v3 which includes your updates.) Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
