Review (maybe some of this is already fixed, I'm reviewing commitdiffs more than the final files, it's easier for me this way):
1) I think that the "Conflicts" should be a "Breaks, Replaces" http://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces 2) debian/flare.install should be called flare-engine.install, the binary package 3) I don't think that the executable "flare" should be renamed, if that's the name upstream uses and doesn't cause conflicts. And this avoid the patch to cmakelists.txt and flare.sh (which would need an additional manpage, etc). 3.1) Maybe only a binary "flare-game" if you want to make it easier for users, a shell as it is now but without .sh in the name (I think that it's recommended not have .sh, .py etc in /usr/bin), and with a simple manpage will do. I don't know what upstream recommend to launch the games though. 4) I think that you leave the game data package named "flare", I think that "flare-game" is more descriptive and follows upstream names, if there's no reason for the contrary 5) "flare-engine" binary package should recommend (or suggest?) "flare-game" with ">= 0.19, <= 0.20"; and the same from the game data to the engine (but with depends instead of just recommends); because often (at least in the past) game and data were changed to suit each other every version 6) I think that .xz (and probably with options -9e) should be used for orig.tar, especially the data... last time that I checked had very significant reduction compared to gzip Sorry for the brevity and the direct style, I had a quite hard day at work but prefered to reply rather than leaving this hanging. Cheers. -- Manuel A. Fernandez Montecelo <[email protected]> -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
