[
https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626420#comment-13626420
]
Knut Anders Hatlen commented on DERBY-6125:
-------------------------------------------
The changes look good to me. Some possible further improvements:
- ClientPooledConnection.getNetXAConnection() has only one caller, and it
consists of just a single call to NetXAConnection's constructor. Maybe we could
get rid of the method and call the constructor directly?
- With the removal of the unused constructor in ClobWriter, the clob_ field is
effectively final, and we could declare it as such.
(I guess at some point we'll want to replace the multitude of traceEntry()
methods with a single one that takes varargs. But maybe not in this JIRA issue.)
> Code clean up in client driver.
> -------------------------------
>
> Key: DERBY-6125
> URL: https://issues.apache.org/jira/browse/DERBY-6125
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Reporter: Dag H. Wanvik
> Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff,
> derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status,
> derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status,
> derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff,
> derby-6125-04-a.status, derby-6125-05-a.diff, derby-6125-05-c.diff,
> derby-6125-05-c.status, derby-6125-05-d.diff, derby-6125-05-d.status,
> derby-6125-visibility-01-a.diff, derby-6125-visibility-01-a.status
>
>
> Clean up unused code, lacking finals, too wide visibility etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
