[ 
https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634964#comment-13634964
 ] 

Knut Anders Hatlen commented on DERBY-6125:
-------------------------------------------

The current situation is in fact even more confusing. For Connection and 
ResultSet, the classes in the net package extend the classes in the am package, 
and getConnection() returns a NetConnection and executeQuery() returns a 
NetResultSet. For Statement, PreparedStatement and CallableStatement, on the 
other hand, the instances returned to the users are instances of the classes in 
the am package. These also have corresponding classes in net, but instead of 
being their base classes, they are wrappers around them. So it seems it's 
tricky to get this consistent simply by renaming classes. Probably some larger 
reorganization would be needed, for example, as you suggested, removing the 
separation between am and net for the JDBC classes, but I guess that's outside 
the scope of this issue. I do however think the patch is an improvement, so it 
gets a +1 from me.
                
> Code clean up in client driver.
> -------------------------------
>
>                 Key: DERBY-6125
>                 URL: https://issues.apache.org/jira/browse/DERBY-6125
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff, 
> derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status, 
> derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status, 
> derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff, 
> derby-6125-04-a.status, derby-6125-05-a.diff, derby-6125-05-c.diff, 
> derby-6125-05-c.status, derby-6125-05-d.diff, derby-6125-05-d.status, 
> derby-6125-imports-01-a.diff, derby-6125-imports-01-a.status, 
> derby-6125-rename-01-c.diff.gz, derby-6125-rename-01-c.stat, 
> derby-6125-visibility-01-a.diff, derby-6125-visibility-01-a.status, 
> derby-6125-visibility-01-b.diff
>
>
> Clean up unused code, lacking finals, too wide visibility etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to