[
https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628996#comment-13628996
]
Knut Anders Hatlen commented on DERBY-6125:
-------------------------------------------
The changes in the import patch look good to me. +1. Also, I'm not aware of any
compatibility impact of renaming the classes. Applications shouldn't access
classes in the am package directly, and if they do, it's not a supported/stable
interface.
I see that the patch modified some empty @throws clauses. Should we just remove
those while we're at it? I don't think they provide much value, since they
don't say anything that we cannot see from the throws clause just a few lines
below.
The patch qualifies some references to "this" with the class name. I don't have
a problem with it, I'm just curious to know how you decided which of them to
qualify. (I've usually qualified them in inner classes to make it clear whether
it refers to the instance of the parent class or the inner class. But it didn't
look like inner classes were involved here.)
I see that you also managed to find and remove some old cruft. Great! :)
> Code clean up in client driver.
> -------------------------------
>
> Key: DERBY-6125
> URL: https://issues.apache.org/jira/browse/DERBY-6125
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Reporter: Dag H. Wanvik
> Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff,
> derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status,
> derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status,
> derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff,
> derby-6125-04-a.status, derby-6125-05-a.diff, derby-6125-05-c.diff,
> derby-6125-05-c.status, derby-6125-05-d.diff, derby-6125-05-d.status,
> derby-6125-imports-01-a.diff, derby-6125-imports-01-a.status,
> derby-6125-visibility-01-a.diff, derby-6125-visibility-01-a.status,
> derby-6125-visibility-01-b.diff
>
>
> Clean up unused code, lacking finals, too wide visibility etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
