[ 
https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633971#comment-13633971
 ] 

Knut Anders Hatlen commented on DERBY-6125:
-------------------------------------------

I think it's a good idea to avoid the naming conflicts to prevent confusion. 
There's potential for new confusion, or at least a small inconsistency, because 
of the renaming, though: ClientConnection lives in one package 
(org.apache.derby.client.am) and is an abstract base class, whereas the 
similarly named ClientPooledConnection and ClientXAConnection live in a 
different package (org.apache.derby.client) and are top-level classes to be 
returned to the user. Probably not a big problem, but I thought I'd raise it so 
that we at least do it knowingly.
                
> Code clean up in client driver.
> -------------------------------
>
>                 Key: DERBY-6125
>                 URL: https://issues.apache.org/jira/browse/DERBY-6125
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff, 
> derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status, 
> derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status, 
> derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff, 
> derby-6125-04-a.status, derby-6125-05-a.diff, derby-6125-05-c.diff, 
> derby-6125-05-c.status, derby-6125-05-d.diff, derby-6125-05-d.status, 
> derby-6125-imports-01-a.diff, derby-6125-imports-01-a.status, 
> derby-6125-rename-01-c.diff.gz, derby-6125-rename-01-c.stat, 
> derby-6125-visibility-01-a.diff, derby-6125-visibility-01-a.status, 
> derby-6125-visibility-01-b.diff
>
>
> Clean up unused code, lacking finals, too wide visibility etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to