[
https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633710#comment-13633710
]
Dag H. Wanvik commented on DERBY-6125:
--------------------------------------
Attaching a (big) patch derby-6125-rename-c which renames the overloaded JDBC
classes in the client driver thus:
am/<JDBCClassName>.java -> am/Client<JDBCClassName>.java
This allows import statements to be used for all JDBC and Derby classes. The
rest of the patch implements that instead of full pathnames in usages. After
this patch, the only overload that needs explicit package path is
"java.util.Date" which would otherwise collide with java.sql.Date. In one
instance, I let a full path remain in order to avoid a compiler warning: the
deprecated use of StringBufferInputStream in ClientClob.java.
Regressions passed.
Caveat: due to the size of the patch there is some concern as always when it
comes to ease of back-porting if it is committed.
Still, I think it represents a good readability clean.up, but I'd like your
opinions as always.
> Code clean up in client driver.
> -------------------------------
>
> Key: DERBY-6125
> URL: https://issues.apache.org/jira/browse/DERBY-6125
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Reporter: Dag H. Wanvik
> Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff,
> derby-6125-01-b.status, derby-6125-02-a.diff, derby-6125-02-a.status,
> derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status,
> derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff,
> derby-6125-04-a.status, derby-6125-05-a.diff, derby-6125-05-c.diff,
> derby-6125-05-c.status, derby-6125-05-d.diff, derby-6125-05-d.status,
> derby-6125-imports-01-a.diff, derby-6125-imports-01-a.status,
> derby-6125-visibility-01-a.diff, derby-6125-visibility-01-a.status,
> derby-6125-visibility-01-b.diff
>
>
> Clean up unused code, lacking finals, too wide visibility etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
