[
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=723838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723838
]
ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/22 17:26
Start Date: 09/Feb/22 17:26
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1034012335
I am way more strict in my development style. If we establish a bad pattern
most developers follow the pattern already implemented.
The first issue with this file is a publicly accessible field (value) that
can already be access from the property (Value). The point of this is to make
the field private. Additionally, I changed this specifically to deprecate over
time and maintain backwards compatibility, which will have to wait a few
releases to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 723838)
Time Spent: 3h 10m (was: 3h)
> Remove accessible field value from GenericFixed
> ------------------------------------------------
>
> Key: AVRO-3368
> URL: https://issues.apache.org/jira/browse/AVRO-3368
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
> get { return _value; }
> }
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to
> _value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
