[
https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278486#comment-14278486
]
Olaf Flebbe commented on BIGTOP-1579:
-------------------------------------
Somehow replying to an jira email does not work as expected.
The logic before was complex and it used misleading naming of variables.
We have 3 cases :
1) Non existing sources: We need to create a tar with LICENSE file
2) ZIP Files: Have to be converted to tar files. With the corner case that it
may have to move one level up.
3) TAR Files. Which have simply to be renamed.
In the case 1 and 2 with have to create a tar afterwards after
creating/unpacking
In case 3 a simple rename does the work.
----
A code path with UNPACK = "tar -xzf" was never used before.
instead the side effect of PATCHES equals empty was used to mark empty packets,
which is misleading — at least.
—
I didn't get this logic correct in the first attempts.
Please reconsider.
> Improve Bigtop Toolchain : Create diff files
> --------------------------------------------
>
> Key: BIGTOP-1579
> URL: https://issues.apache.org/jira/browse/BIGTOP-1579
> Project: Bigtop
> Issue Type: Bug
> Components: build
> Reporter: Olaf Flebbe
> Assignee: Olaf Flebbe
> Fix For: 0.9.0
>
> Attachments: 0001-BIGTOP-1579-Implement-patching-for-Bigtop.patch,
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch,
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch,
> 0002-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch
>
>
> Right now, we apply changes/patches in the do-build-component script in the
> bigtop-packages/common/<package> part of the build process .
> Would be cleaner and easier to use the RPM / Deb functionality of RPMbuild /
> debuild to apply patches. But right now the gradle script is not flexible
> enough. Since make is now obsolete we can improve this situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
