[
https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279246#comment-14279246
]
Konstantin Boudnik commented on BIGTOP-1579:
--------------------------------------------
Thanks for the explanation. I agree that the original code was a bit messy -
sorry about it. Although I have an excuse: I was trying to replicate the make
stuff ;) At any rate... I think the change you've made is in fact correct:
thanks for standing your ground!
I wish there's a way to have a test for tasks like this... IMO a test is the
best way to document the logic like you've described above. Can you think of a
way to test this stuff?
+1 otherwise. I will a bit to see if anyone have any comments on how to test
this type of build functionality. Will commit this later today or in the
morning.
> Improve Bigtop Toolchain : Create diff files
> --------------------------------------------
>
> Key: BIGTOP-1579
> URL: https://issues.apache.org/jira/browse/BIGTOP-1579
> Project: Bigtop
> Issue Type: Bug
> Components: build
> Reporter: Olaf Flebbe
> Assignee: Olaf Flebbe
> Fix For: 0.9.0
>
> Attachments: 0001-BIGTOP-1579-Implement-patching-for-Bigtop.patch,
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch,
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch,
> 0002-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch
>
>
> Right now, we apply changes/patches in the do-build-component script in the
> bigtop-packages/common/<package> part of the build process .
> Would be cleaner and easier to use the RPM / Deb functionality of RPMbuild /
> debuild to apply patches. But right now the gradle script is not flexible
> enough. Since make is now obsolete we can improve this situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
