[ 
https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279365#comment-14279365
 ] 

Konstantin Boudnik commented on BIGTOP-1579:
--------------------------------------------

Actually, what I had in mind is some sort of unit tests for the logic inside of 
these tasks. I am not picking at the one you've changed, but we have a number 
of complex ones and it'd be nice to be able to tests them even before the build 
starts. E.g. look at {{org.apache.bigtop.TestBuildUtils}} which tests the logic 
of BOM parsing, etc.

But I guess this wish is going over and above the scope of this ticket. I will 
commit this as the fix is proper and correctly executed. But it'd be nice to 
think about how we can test our build logic.

> Improve Bigtop Toolchain : Create diff files
> --------------------------------------------
>
>                 Key: BIGTOP-1579
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1579
>             Project: Bigtop
>          Issue Type: Bug
>          Components: build
>            Reporter: Olaf Flebbe
>            Assignee: Olaf Flebbe
>             Fix For: 0.9.0
>
>         Attachments: 0001-BIGTOP-1579-Implement-patching-for-Bigtop.patch, 
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch, 
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch, 
> 0002-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch
>
>
> Right now, we apply changes/patches in the do-build-component script in the 
> bigtop-packages/common/<package> part of the build process .
> Would be cleaner and easier to use the RPM / Deb functionality of RPMbuild / 
> debuild to apply patches. But right now the gradle script is not flexible 
> enough. Since make is now obsolete we can improve this situation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to