ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r318116405
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/metadata/Metadata_V4.java
##########
@@ -311,7 +314,8 @@ public Long getRowCount() {
public ColumnTypeMetadata_v4() {
}
- public ColumnTypeMetadata_v4(String[] name,
PrimitiveType.PrimitiveTypeName primitiveType, OriginalType originalType, int
precision, int scale, int repetitionLevel, int definitionLevel, long
totalNullCount, boolean isInteresting) {
+ public ColumnTypeMetadata_v4(String[] name,
PrimitiveType.PrimitiveTypeName primitiveType, OriginalType originalType, int
precision, int scale, int repetitionLevel,
Review comment:
10 arguments, isn't it's time for builder ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
