ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r318195592
##########
File path: exec/vector/src/main/codegen/templates/BaseReader.java
##########
@@ -48,6 +49,14 @@
int size();
void copyAsValue(MapWriter writer);
}
+
+ public interface DictReader extends RepeatedMapReader {
Review comment:
Please provide javadoc for interface and methods. This is really very
interesting to know difference between
```java
int find(String key);
int find(int key);
```
and when to use them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
