ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r318158014
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/FieldIdUtil.java
##########
@@ -58,8 +58,17 @@ public static TypedFieldId
getFieldIdIfMatchesUnion(UnionVector unionVector, Typ
}
- public static TypedFieldId getFieldIdIfMatches(ValueVector vector,
TypedFieldId.Builder builder, boolean addToBreadCrumb, PathSegment seg) {
- if (vector instanceof RepeatedMapVector && seg != null && seg.isArray() &&
!seg.isLastPath()) {
+ public static TypedFieldId getFieldIdIfMatches(ValueVector vector,
TypedFieldId.Builder builder,
Review comment:
please add javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
