[
https://issues.apache.org/jira/browse/GOBBLIN-1804?focusedWorklogId=853208&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853208
]
ASF GitHub Bot logged work on GOBBLIN-1804:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/23 16:47
Start Date: 27/Mar/23 16:47
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3664:
URL: https://github.com/apache/gobblin/pull/3664#discussion_r1149534093
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java:
##########
@@ -154,6 +154,53 @@ private String getErrorMessage(FlowSpec flowSpec) {
}
return "Could not form JSON in FlowConfigV2ResourceLocalHandler";
}
+
+ /**
+ * Update flowConfig locally and trigger all listeners iff @param
triggerListener is set to true
+ */
+ @Override
+ public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig,
boolean triggerListener, long modifiedWatermark) {
Review Comment:
FYI, based on additional offline convo we had, I took a stab at combining
the change into the v1 endpoint handler -
https://github.com/apache/gobblin/pull/3665
unless there's an active reason to preserve this (surprising/incorrect)
behavior in v1, I prefer that approach, as it reduces code duplication while
also bringing correctness more widely.
Issue Time Tracking
-------------------
Worklog Id: (was: 853208)
Time Spent: 1.5h (was: 1h 20m)
> FlowConfigV2 should reject updates that fail compilation and return service
> error code
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1804
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1804
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Users can create a working flow configuration, but when the config fails
> compilation it is rejected.
> Relatedly, when users try to update a working flow configuration with one
> that fails compilation, the update returns success, despite internal logging
> recording:
> "Ignoring the spec gobblin-flow:/testGroup/testName/. isExplain: false,
> compileSuccess: false, master: true".
> A subsequent GET request for that flow config shows the update didn't
> actually happen. thus the update's response was misleading and should be
> corrected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
