[
https://issues.apache.org/jira/browse/GOBBLIN-1804?focusedWorklogId=853502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853502
]
ASF GitHub Bot logged work on GOBBLIN-1804:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/23 19:32
Start Date: 28/Mar/23 19:32
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3665:
URL: https://github.com/apache/gobblin/pull/3665#issuecomment-1487487583
##
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3665](https://codecov.io/gh/apache/gobblin/pull/3665?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(fae3cb5) into
[master](https://codecov.io/gh/apache/gobblin/commit/549462f4a90c31f84e7a2aab6b8aee144413a7ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(549462f) will **decrease** coverage by `2.30%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3665 +/- ##
============================================
- Coverage 46.96% 44.66% -2.30%
+ Complexity 10781 2088 -8693
============================================
Files 2138 411 -1727
Lines 84012 17692 -66320
Branches 9336 2156 -7180
============================================
- Hits 39457 7903 -31554
+ Misses 40982 8933 -32049
+ Partials 3573 856 -2717
```
[see 1729 files with indirect coverage
changes](https://codecov.io/gh/apache/gobblin/pull/3665/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 853502)
Time Spent: 1h 50m (was: 1h 40m)
> FlowConfigV2 should reject updates that fail compilation and return service
> error code
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1804
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1804
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Users can create a working flow configuration, but when the config fails
> compilation it is rejected.
> Relatedly, when users try to update a working flow configuration with one
> that fails compilation, the update returns success, despite internal logging
> recording:
> "Ignoring the spec gobblin-flow:/testGroup/testName/. isExplain: false,
> compileSuccess: false, master: true".
> A subsequent GET request for that flow config shows the update didn't
> actually happen. thus the update's response was misleading and should be
> corrected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
