[
https://issues.apache.org/jira/browse/GOBBLIN-1804?focusedWorklogId=853212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853212
]
ASF GitHub Bot logged work on GOBBLIN-1804:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/23 16:51
Start Date: 27/Mar/23 16:51
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3665:
URL: https://github.com/apache/gobblin/pull/3665#discussion_r1149542166
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java:
##########
@@ -305,4 +322,43 @@ public static FlowSpec createFlowSpecForConfig(FlowConfig
flowConfig) {
throw new FlowConfigLoggedException(HttpStatus.S_400_BAD_REQUEST, "bad
URI " + flowConfig.getTemplateUris(), e);
}
}
+
+ protected String getErrorMessage(FlowSpec flowSpec) {
+ StringBuilder message = new StringBuilder("Flow was not compiled
successfully.");
+ Map<String, ArrayList<String>> allErrors = new HashMap<>();
Review Comment:
FYI, I replaced `HashTable`, as that's a non-canonical collection (even
surprising to see in java 1.8 code). in fact, I first wondered whether there
was a specific reason, perhaps due to json serialization... but AFAICT, the
current unit tests exercise this function to thus validate that `HashMap` works
just as well.
Issue Time Tracking
-------------------
Worklog Id: (was: 853212)
Time Spent: 1h 40m (was: 1.5h)
> FlowConfigV2 should reject updates that fail compilation and return service
> error code
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1804
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1804
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Users can create a working flow configuration, but when the config fails
> compilation it is rejected.
> Relatedly, when users try to update a working flow configuration with one
> that fails compilation, the update returns success, despite internal logging
> recording:
> "Ignoring the spec gobblin-flow:/testGroup/testName/. isExplain: false,
> compileSuccess: false, master: true".
> A subsequent GET request for that flow config shows the update didn't
> actually happen. thus the update's response was misleading and should be
> corrected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
