[
https://issues.apache.org/jira/browse/GOBBLIN-1804?focusedWorklogId=852917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-852917
]
ASF GitHub Bot logged work on GOBBLIN-1804:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/23 19:25
Start Date: 24/Mar/23 19:25
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3664:
URL: https://github.com/apache/gobblin/pull/3664#issuecomment-1483304583
##
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3664?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3664](https://codecov.io/gh/apache/gobblin/pull/3664?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(835414c) into
[master](https://codecov.io/gh/apache/gobblin/commit/7675dc43dd7128bb2daedb8c6b826e8fcc9104c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7675dc4) will **increase** coverage by `1.18%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3664 +/- ##
============================================
+ Coverage 46.97% 48.15% +1.18%
+ Complexity 10780 3464 -7316
============================================
Files 2138 689 -1449
Lines 83992 27668 -56324
Branches 9332 3235 -6097
============================================
- Hits 39455 13324 -26131
+ Misses 40959 12984 -27975
+ Partials 3578 1360 -2218
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3664?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/gobblin/pull/3664?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==)
| `15.68% <ø> (ø)` | |
|
[...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/gobblin/pull/3664?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh)
| `0.00% <0.00%> (ø)` | |
... and [1455 files with indirect coverage
changes](https://codecov.io/gh/apache/gobblin/pull/3664/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 852917)
Time Spent: 1h (was: 50m)
> FlowConfigV2 should reject updates that fail compilation and return service
> error code
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1804
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1804
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Users can create a working flow configuration, but when the config fails
> compilation it is rejected.
> Relatedly, when users try to update a working flow configuration with one
> that fails compilation, the update returns success, despite internal logging
> recording:
> "Ignoring the spec gobblin-flow:/testGroup/testName/. isExplain: false,
> compileSuccess: false, master: true".
> A subsequent GET request for that flow config shows the update didn't
> actually happen. thus the update's response was misleading and should be
> corrected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
