[
https://issues.apache.org/jira/browse/GOBBLIN-1804?focusedWorklogId=852891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-852891
]
ASF GitHub Bot logged work on GOBBLIN-1804:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/23 18:13
Start Date: 24/Mar/23 18:13
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3664:
URL: https://github.com/apache/gobblin/pull/3664#discussion_r1147916904
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java:
##########
@@ -154,6 +154,53 @@ private String getErrorMessage(FlowSpec flowSpec) {
}
return "Could not form JSON in FlowConfigV2ResourceLocalHandler";
}
+
+ /**
+ * Update flowConfig locally and trigger all listeners iff @param
triggerListener is set to true
+ */
+ @Override
+ public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig,
boolean triggerListener, long modifiedWatermark) {
Review Comment:
the alternative to overriding here in the `FlowConfigV2ResourceLocalHandler`
would be to modify the impl. in the `FlowConfigResourceLocalHandler` (which is
the super class). I don't know enough about the history (of why we still
retain both versions) to judge what's most appropriate.
situating in the super class would bring this behavior to FlowConfig and
FlowConfigV2 APIs. clearly that would change the response semantics of both,
although it would otherwise remain backwards compatible (e.g. for the request
format). of course this current change evolves the FlowConfigV2 API, so the
question is really whether we wish also to evolve the FlowConfig API's update
as well.
either is fine w/ me, so let me know the preference
Issue Time Tracking
-------------------
Worklog Id: (was: 852891)
Time Spent: 0.5h (was: 20m)
> FlowConfigV2 should reject updates that fail compilation and return service
> error code
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1804
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1804
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Users can create a working flow configuration, but when the config fails
> compilation it is rejected.
> Relatedly, when users try to update a working flow configuration with one
> that fails compilation, the update returns success, despite internal logging
> recording:
> "Ignoring the spec gobblin-flow:/testGroup/testName/. isExplain: false,
> compileSuccess: false, master: true".
> A subsequent GET request for that flow config shows the update didn't
> actually happen. thus the update's response was misleading and should be
> corrected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
