[
https://issues.apache.org/jira/browse/GOBBLIN-1937?focusedWorklogId=887305&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887305
]
ASF GitHub Bot logged work on GOBBLIN-1937:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/23 00:01
Start Date: 26/Oct/23 00:01
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#discussion_r1372425872
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -79,6 +79,7 @@ public class FlowTriggerHandler {
private ContextAwareCounter noLongerLeasingStatusCount;
private ContextAwareCounter jobDoesNotExistInSchedulerCount;
private ContextAwareCounter failedToSetEventReminderCount;
+ private ContextAwareMeter numRemindersDoingMissedWork;
Review Comment:
this name over-interprets ("missed" vs. "unfinished"; "doing" vs.
"attempting").
if we stuck "strictly to the facts", could we say
`numLeasesObtainedDueToReminder`?
...hey, wait! ...although I do prefer the `num` prefix, I see the convention
above seems instead to be the `Count` suffix. so maybe
`leaseObtainedUponReminderCount`?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -143,6 +135,15 @@ protected void processMessage(DecodeableKafkaRecord
message) {
return;
}
+ // Needs to be done after, filtering out heartbeat values that do have
valid null dagActionTypes
+ if (value.getDagAction() == null) {
Review Comment:
at first, I couldn't figure out "after" what? is this accurate rephrasing?
```
// check after `shouldProcessMessage` filters out heartbeat messages (w/
`dagActionType == null`)
```
another way to help indicate would be to replace `if` w/ `else if`
Issue Time Tracking
-------------------
Worklog Id: (was: 887305)
Time Spent: 20m (was: 10m)
> Quantify Missed Work Completed by Reminders
> -------------------------------------------
>
> Key: GOBBLIN-1937
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1937
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Measure the amount of work that would have been missed by a participant
> otherwise completed by the reminder event concept. This can be done by
> checking the number of reminder events that actually obtain a lease to
> re-trigger a flow launch. Reminder events that see another lease is in
> progress are not included to avoid double counting the participant actually
> doing the work on reminder case.
> Additionally, address a bug to filter out heartbeat events _before_
> attempting to extract the {{FlowActionType}} from
> {{DagActionStoreChangeEvents}} because heartbeat events have null
> {{{}FlowActionTypes{}}}, causing the heartbeats to be rightfully skipped but
> for the wrong reason.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)