[
https://issues.apache.org/jira/browse/GOBBLIN-1937?focusedWorklogId=887306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887306
]
ASF GitHub Bot logged work on GOBBLIN-1937:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/23 01:04
Start Date: 26/Oct/23 01:04
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#issuecomment-1780259640
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3808?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3808](https://app.codecov.io/gh/apache/gobblin/pull/3808?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(9f582aa) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/9a516d3b8e832acb86acaf7b551e5fba13728531?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(9a516d3) will **decrease** coverage by `1.31%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3808 +/- ##
============================================
- Coverage 47.33% 46.03% -1.31%
+ Complexity 10987 2179 -8808
============================================
Files 2155 416 -1739
Lines 85241 17967 -67274
Branches 9480 2191 -7289
============================================
- Hits 40353 8271 -32082
+ Misses 41226 8813 -32413
+ Partials 3662 883 -2779
```
[see 1745 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3808/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 887306)
Time Spent: 0.5h (was: 20m)
> Quantify Missed Work Completed by Reminders
> -------------------------------------------
>
> Key: GOBBLIN-1937
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1937
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Measure the amount of work that would have been missed by a participant
> otherwise completed by the reminder event concept. This can be done by
> checking the number of reminder events that actually obtain a lease to
> re-trigger a flow launch. Reminder events that see another lease is in
> progress are not included to avoid double counting the participant actually
> doing the work on reminder case.
> Additionally, address a bug to filter out heartbeat events _before_
> attempting to extract the {{FlowActionType}} from
> {{DagActionStoreChangeEvents}} because heartbeat events have null
> {{{}FlowActionTypes{}}}, causing the heartbeats to be rightfully skipped but
> for the wrong reason.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)