[ 
https://issues.apache.org/jira/browse/GOBBLIN-1937?focusedWorklogId=887474&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887474
 ]

ASF GitHub Bot logged work on GOBBLIN-1937:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Oct/23 21:01
            Start Date: 26/Oct/23 21:01
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#discussion_r1373810362


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/ChangeMonitorUtils.java:
##########
@@ -28,20 +30,24 @@ private ChangeMonitorUtils() {
   }
 
   /**
-   * Performs checks for duplicate messages and heartbeat operation prior to 
processing a message. Returns true if
-   * the pre-conditions above don't apply and we should proceed processing the 
change event
+   * Performs checks for duplicate messages, heartbeat message types, or null 
dag action types all of which cannot or
+   * should not be processed. Returns true if the pre-conditions above don't 
apply, and we should proceed processing
+   * the change event
    */
-  public static boolean shouldProcessMessage(String changeIdentifier, 
LoadingCache<String, String> cache,
-      String operation, String timestamp) {
+  public static boolean isValidAndUniqueMessage(String changeIdentifier, 
LoadingCache<String, String> cache,
+      String operation, String timestamp, ContextAwareMeter 
duplicateMessagesMeter,
+      ContextAwareMeter heartbeatMessagesMeter) {

Review Comment:
   nit: I would put all the elements from the message together as the first 
params, and then the cache and the meters





Issue Time Tracking
-------------------

    Worklog Id:     (was: 887474)
    Time Spent: 1h 50m  (was: 1h 40m)

> Quantify Missed Work Completed by Reminders
> -------------------------------------------
>
>                 Key: GOBBLIN-1937
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1937
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Measure the amount of work that would have been missed by a participant 
> otherwise completed by the reminder event concept. This can be done by 
> checking the number of reminder events that actually obtain a lease to 
> re-trigger a flow launch. Reminder events that see another lease is in 
> progress are not included to avoid double counting the participant actually 
> doing the work on reminder case. 
> Additionally, address a bug to filter out heartbeat events _before_ 
> attempting to extract the {{FlowActionType}} from 
> {{DagActionStoreChangeEvents}} because heartbeat events have null 
> {{{}FlowActionTypes{}}}, causing the heartbeats to be rightfully skipped but 
> for the wrong reason. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to