[
https://issues.apache.org/jira/browse/GOBBLIN-1937?focusedWorklogId=887423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887423
]
ASF GitHub Bot logged work on GOBBLIN-1937:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/23 15:51
Start Date: 26/Oct/23 15:51
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#discussion_r1373393108
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -79,6 +79,7 @@ public class FlowTriggerHandler {
private ContextAwareCounter noLongerLeasingStatusCount;
private ContextAwareCounter jobDoesNotExistInSchedulerCount;
private ContextAwareCounter failedToSetEventReminderCount;
+ private ContextAwareMeter numRemindersDoingMissedWork;
Review Comment:
I also prefer the `num` prefix, but `count` made more sense for some of the
names above so I'll stick with that convention.
Issue Time Tracking
-------------------
Worklog Id: (was: 887423)
Time Spent: 1h (was: 50m)
> Quantify Missed Work Completed by Reminders
> -------------------------------------------
>
> Key: GOBBLIN-1937
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1937
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Measure the amount of work that would have been missed by a participant
> otherwise completed by the reminder event concept. This can be done by
> checking the number of reminder events that actually obtain a lease to
> re-trigger a flow launch. Reminder events that see another lease is in
> progress are not included to avoid double counting the participant actually
> doing the work on reminder case.
> Additionally, address a bug to filter out heartbeat events _before_
> attempting to extract the {{FlowActionType}} from
> {{DagActionStoreChangeEvents}} because heartbeat events have null
> {{{}FlowActionTypes{}}}, causing the heartbeats to be rightfully skipped but
> for the wrong reason.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)