[ 
https://issues.apache.org/jira/browse/GOBBLIN-1937?focusedWorklogId=887472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887472
 ]

ASF GitHub Bot logged work on GOBBLIN-1937:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Oct/23 20:46
            Start Date: 26/Oct/23 20:46
    Worklog Time Spent: 10m 
      Work Description: umustafi commented on PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#issuecomment-1781871683

   Tried to add a unit test for `DagActionStoreMonitor.processMessage` to 
ensure that `heartbeat` messages or null `dagActionType` messages are processed 
in the correct order but these tests will need to be e2e tests that instantiate 
a `DagActionStoreMonitor` instance, created DecodeableKafkaRecords, and can 
properly parse a variety of messages (insert, delete, heartbeat, etc...) but 
it's going to be a bigger change and LOE than the scope of the current PR. I 
will follow up with a separate PR for that. 




Issue Time Tracking
-------------------

    Worklog Id:     (was: 887472)
    Time Spent: 1h 40m  (was: 1.5h)

> Quantify Missed Work Completed by Reminders
> -------------------------------------------
>
>                 Key: GOBBLIN-1937
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1937
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Measure the amount of work that would have been missed by a participant 
> otherwise completed by the reminder event concept. This can be done by 
> checking the number of reminder events that actually obtain a lease to 
> re-trigger a flow launch. Reminder events that see another lease is in 
> progress are not included to avoid double counting the participant actually 
> doing the work on reminder case. 
> Additionally, address a bug to filter out heartbeat events _before_ 
> attempting to extract the {{FlowActionType}} from 
> {{DagActionStoreChangeEvents}} because heartbeat events have null 
> {{{}FlowActionTypes{}}}, causing the heartbeats to be rightfully skipped but 
> for the wrong reason. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to