[
https://issues.apache.org/jira/browse/GOBBLIN-1937?focusedWorklogId=887311&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887311
]
ASF GitHub Bot logged work on GOBBLIN-1937:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/23 03:26
Start Date: 26/Oct/23 03:26
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3808:
URL: https://github.com/apache/gobblin/pull/3808#discussion_r1372412643
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/ServiceMetricNames.java:
##########
@@ -35,13 +35,14 @@ public class ServiceMetricNames {
public static final String FLOW_ORCHESTRATION_DELAY = GOBBLIN_SERVICE_PREFIX
+ ".flowOrchestration.delay";
// Flow Trigger Handler
- public static final String FLOW_TRIGGER_HANDLER_PREFIX =
"flowTriggerHandler";
- public static final String GOBBLIN_FLOW_TRIGGER_HANDLER_NUM_FLOWS_SUBMITTED
= ServiceMetricNames.GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX
+ ".numFlowsSubmitted";
- public static final String FLOW_TRIGGER_HANDLER_LEASE_OBTAINED_COUNT =
GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX + ".leaseObtained";
- public static final String FLOW_TRIGGER_HANDLER_LEASED_TO_ANOTHER_COUNT =
GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX + ".leasedToAnother";
- public static final String FLOW_TRIGGER_HANDLER_NO_LONGER_LEASING_COUNT =
GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX + ".noLongerLeasing";
- public static final String FLOW_TRIGGER_HANDLER_JOB_DOES_NOT_EXIST_COUNT =
GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX +
".jobDoesNotExistInScheduler";
- public static final String FLOW_TRIGGER_HANDLER_FAILED_TO_SET_REMINDER_COUNT
= GOBBLIN_SERVICE_PREFIX + "." + FLOW_TRIGGER_HANDLER_PREFIX +
".failedToSetReminderCount";
+ public static final String FLOW_TRIGGER_HANDLER_PREFIX =
GOBBLIN_SERVICE_PREFIX + "." + "flowTriggerHandler";
Review Comment:
Is it possible for us to add the dot to the GOBBLIN_SERVICE_PREFIX and
remove manually adding the dots in subsequent metric names? Might be a pain to
do but I think this will lead to a better codebase since this keeps getting
missed
Issue Time Tracking
-------------------
Worklog Id: (was: 887311)
Time Spent: 50m (was: 40m)
> Quantify Missed Work Completed by Reminders
> -------------------------------------------
>
> Key: GOBBLIN-1937
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1937
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Measure the amount of work that would have been missed by a participant
> otherwise completed by the reminder event concept. This can be done by
> checking the number of reminder events that actually obtain a lease to
> re-trigger a flow launch. Reminder events that see another lease is in
> progress are not included to avoid double counting the participant actually
> doing the work on reminder case.
> Additionally, address a bug to filter out heartbeat events _before_
> attempting to extract the {{FlowActionType}} from
> {{DagActionStoreChangeEvents}} because heartbeat events have null
> {{{}FlowActionTypes{}}}, causing the heartbeats to be rightfully skipped but
> for the wrong reason.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)