[
https://issues.apache.org/jira/browse/GOBBLIN-2002?focusedWorklogId=904982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904982
]
ASF GitHub Bot logged work on GOBBLIN-2002:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/24 21:11
Start Date: 14/Feb/24 21:11
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1490073367
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementStateStore.java:
##########
@@ -32,40 +32,44 @@
* and allows add/delete and other functions.
*/
public interface DagManagementStateStore {
- Dag<JobExecutionPlan> getDag(String dagId) throws IOException;
- Dag<JobExecutionPlan> getFailedDag(String dagId) throws IOException;
- void addDag(String dagId, Dag<JobExecutionPlan> dag);
- boolean containsDag(String dagId);
- Dag.DagNode<JobExecutionPlan> getDagNode(String dagNodeId);
- Dag<JobExecutionPlan> getParentDag(Dag.DagNode<JobExecutionPlan> dagNode);
- List<Dag.DagNode<JobExecutionPlan>> getDagNodes(String dagId) throws
IOException;
- List<Dag.DagNode<JobExecutionPlan>> getAllDagNodes() throws IOException;
- boolean addCleanUpDag(String dagId);
- void addDagNodeState(String dagId, Dag.DagNode<JobExecutionPlan> dagNode);
- void deleteDagNodeState(String dagId, Dag.DagNode<JobExecutionPlan> dagNode);
-
+ void addDag(Dag<JobExecutionPlan> dag);
/**
* Persist the {@link Dag} to the backing store.
* This is not an actual checkpoint but more like a Write-ahead log, where
uncommitted job will be persisted
* and be picked up again when leader transition happens.
* @param dag The dag submitted to {@link DagManager}
*/
void writeCheckpoint(Dag<JobExecutionPlan> dag) throws IOException;
- void writeFailedDagCheckpoint(Dag<JobExecutionPlan> dag) throws IOException;
-
+ boolean containsDag(String dagId);
+ Dag<JobExecutionPlan> getDag(DagManager.DagId dagId) throws IOException;
+ /**
+ * Return a list of all dag IDs contained in the dag state store.
+ */
+ Set<String> getDagIds() throws IOException;
Review Comment:
the underlying call to `DagStateStore` returns Set<String>
Do you want to modify it there to return `Set<DagManager.DagId>` or do you
want to convert each element of the set here ? btw, there we can convert a
DagId to string, but not the vice versa.
Issue Time Tracking
-------------------
Worklog Id: (was: 904982)
Time Spent: 3h 50m (was: 3h 40m)
> create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager,
> DagStateStore and in-memory dag maps used in DagManager
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2002
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2002
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> this will help in refactoring DagManager
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
