[
https://issues.apache.org/jira/browse/GOBBLIN-2002?focusedWorklogId=905026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-905026
]
ASF GitHub Bot logged work on GOBBLIN-2002:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/24 08:10
Start Date: 15/Feb/24 08:10
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1490574061
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagStateStore.java:
##########
@@ -134,6 +134,11 @@ public void cleanUp(String dagId)
this.totalDagCount.dec();
}
+ @Override
+ public boolean existsDag(String dagId) throws IOException {
Review Comment:
I wanted either all of the signatures in DSS have `DagId` or none of them
have `DagId` for sake of consistency.
Issue Time Tracking
-------------------
Worklog Id: (was: 905026)
Time Spent: 4.5h (was: 4h 20m)
> create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager,
> DagStateStore and in-memory dag maps used in DagManager
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2002
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2002
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> this will help in refactoring DagManager
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
