[
https://issues.apache.org/jira/browse/GOBBLIN-2002?focusedWorklogId=905165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-905165
]
ASF GitHub Bot logged work on GOBBLIN-2002:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/24 21:16
Start Date: 15/Feb/24 21:16
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1491599812
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/DagNodeId.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.flowgraph;
+
+import com.google.common.base.Joiner;
+
+import lombok.Data;
+
+
+@Data
+public class DagNodeId {
Review Comment:
every class needs javadoc... suggest mentioning relationship to
`Dag.DagNode<JEP>`
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagStateStore.java:
##########
@@ -160,21 +165,21 @@ public Set<String> getDagIds() throws IOException {
* Convert a state store entry into a dag ID
* e.g. storeName = group1_name1, tableName = 1234 gives dagId
group1_name1_1234
*/
- private String entryToDagId(String storeName, String tableName) {
+ public static String entryToDagId(String storeName, String tableName) {
return
Joiner.on(ServiceConfigKeys.DAG_STORE_KEY_SEPARATION_CHARACTER).join(storeName,
tableName);
}
/**
* Return a storeName given a dagId. Store name is defined as
flowGroup_flowName.
*/
- private String getStoreNameFromDagId(String dagId) {
+ public static String getStoreNameFromDagId(String dagId) {
return dagId.substring(0,
dagId.lastIndexOf(ServiceConfigKeys.DAG_STORE_KEY_SEPARATION_CHARACTER));
}
/**
* Return a tableName given a dagId. Table name is defined as the
flowExecutionId.
*/
- private String getTableNameFromDagId(String dagId) {
+ public static String getTableNameFromDagId(String dagId) {
Review Comment:
who's calling these? I missed why they needed to become public.
(these encodings really do feel like something to remain encapsulated
entirely inside this class)
Issue Time Tracking
-------------------
Worklog Id: (was: 905165)
Time Spent: 4h 40m (was: 4.5h)
> create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager,
> DagStateStore and in-memory dag maps used in DagManager
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2002
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2002
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> this will help in refactoring DagManager
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
