[jira] [Work logged] (GOBBLIN-2002) create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager, DagStateStore and in-memory dag maps used in DagManager

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-2002?focusedWorklogId=905382&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-905382
 ]

ASF GitHub Bot logged work on GOBBLIN-2002:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Feb/24 17:20
            Start Date: 16/Feb/24 17:20
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1492773026


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagStateStore.java:
##########
@@ -160,21 +165,21 @@ public Set<String> getDagIds() throws IOException {
    * Convert a state store entry into a dag ID
    * e.g. storeName = group1_name1, tableName = 1234 gives dagId 
group1_name1_1234
    */
-  private String entryToDagId(String storeName, String tableName) {
+  public static String entryToDagId(String storeName, String tableName) {
     return 
Joiner.on(ServiceConfigKeys.DAG_STORE_KEY_SEPARATION_CHARACTER).join(storeName, 
tableName);
   }
 
   /**
    * Return a storeName given a dagId. Store name is defined as 
flowGroup_flowName.
    */
-  private String getStoreNameFromDagId(String dagId) {
+  public static String getStoreNameFromDagId(String dagId) {
     return dagId.substring(0, 
dagId.lastIndexOf(ServiceConfigKeys.DAG_STORE_KEY_SEPARATION_CHARACTER));
   }
 
   /**
    * Return a tableName given a dagId. Table name is defined as the 
flowExecutionId.
    */
-  private String getTableNameFromDagId(String dagId) {
+  public static String getTableNameFromDagId(String dagId) {

Review Comment:
   yea they can remain private





Issue Time Tracking
-------------------

    Worklog Id:     (was: 905382)
    Time Spent: 5h  (was: 4h 50m)

> create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager, 
> DagStateStore and in-memory dag maps used in DagManager
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-2002
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2002
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> this will help in refactoring DagManager



--
This message was sent by Atlassian Jira
(v8.20.10#820010)