[ https://issues.apache.org/jira/browse/GOBBLIN-2002?focusedWorklogId=905167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-905167 ]
ASF GitHub Bot logged work on GOBBLIN-2002: ------------------------------------------- Author: ASF GitHub Bot Created on: 15/Feb/24 21:17 Start Date: 15/Feb/24 21:17 Worklog Time Spent: 10m Work Description: phet commented on code in PR #3878: URL: https://github.com/apache/gobblin/pull/3878#discussion_r1491599812 ########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/DagNodeId.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.flowgraph; + +import com.google.common.base.Joiner; + +import lombok.Data; + + +@Data +public class DagNodeId { Review Comment: every class needs javadoc... suggest that's a good place to mention the relationship to `Dag.DagNode<JEP>` Issue Time Tracking ------------------- Worklog Id: (was: 905167) Time Spent: 4h 50m (was: 4h 40m) > create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager, > DagStateStore and in-memory dag maps used in DagManager > ------------------------------------------------------------------------------------------------------------------------------- > > Key: GOBBLIN-2002 > URL: https://issues.apache.org/jira/browse/GOBBLIN-2002 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: Arjun Singh Bora > Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > > this will help in refactoring DagManager -- This message was sent by Atlassian Jira (v8.20.10#820010)