[
https://issues.apache.org/jira/browse/GOBBLIN-2002?focusedWorklogId=905024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-905024
]
ASF GitHub Bot logged work on GOBBLIN-2002:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/24 08:05
Start Date: 15/Feb/24 08:05
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1490568214
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementStateStore.java:
##########
@@ -32,44 +33,49 @@
* and allows add/delete and other functions.
*/
public interface DagManagementStateStore {
- void addDag(Dag<JobExecutionPlan> dag);
/**
* Persist the {@link Dag} to the backing store.
- * This is not an actual checkpoint but more like a Write-ahead log, where
uncommitted job will be persisted
- * and be picked up again when leader transition happens.
+ * It is named this because it is usually called to checkpoint any changes
in {@link Dag} or in its {@link Dag.DagNode}s.
* @param dag The dag submitted to {@link DagManager}
*/
void writeCheckpoint(Dag<JobExecutionPlan> dag) throws IOException;
Review Comment:
Using this name, I wanted to emphasize on its use pattern "It is named this
because it is usually called to checkpoint any changes in {@link Dag}"
Issue Time Tracking
-------------------
Worklog Id: (was: 905024)
Time Spent: 4h 20m (was: 4h 10m)
> create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager,
> DagStateStore and in-memory dag maps used in DagManager
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2002
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2002
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> this will help in refactoring DagManager
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
