[
https://issues.apache.org/jira/browse/GOBBLIN-2002?focusedWorklogId=905398&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-905398
]
ASF GitHub Bot logged work on GOBBLIN-2002:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/24 18:38
Start Date: 16/Feb/24 18:38
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1492828850
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementStateStore.java:
##########
@@ -74,16 +78,10 @@ public interface DagManagementStateStore {
*/
List<Dag<JobExecutionPlan>> getDags() throws IOException;
- /**
- * Return a list of all dag IDs contained in the dag state store.
- */
- Set<String> getDagIds() throws IOException;
- Set<String> getFailedDagIds() throws IOException;
-
/**
* Initialize with the provided set of dags.
*/
- void initQuotaManageer(Collection<Dag<JobExecutionPlan>> dags) throws
IOException;
+ void initQuota(Collection<Dag<JobExecutionPlan>> dags) throws IOException;
Review Comment:
If you prefer, we can punt on this to a later PR... but I do anticipate a
startup process like:
1. load all dags
2. adjust quota based on those dags (possibly a no-op... however should be
called, not presumed to skip!)
3. addDagNodes based on those dags
Issue Time Tracking
-------------------
Worklog Id: (was: 905398)
Time Spent: 6h 10m (was: 6h)
> create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager,
> DagStateStore and in-memory dag maps used in DagManager
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2002
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2002
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> this will help in refactoring DagManager
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
