Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-2198: Differentiate queries in exceptional states in web 
UI
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2625/1/www/queries.tmpl
File www/queries.tmpl:

Line 22: in flight
> Sorry I misunderstood exactly what would be in this list and what I said ab
Done


Line 60:   {{num_waiting_queries}} waiting on client
> or "ready for client action"?
I think 'waiting on client' is better. 'ready for client action' sounds to me 
more like an initial state with more work to follow, eg. we just generated some 
results and they're 'ready' to be retrieved, whereas this is more of a finished 
state, but I don't have strong feelings either way.


Line 77:     <th>Action</th>
> As we just discussed in person, I also think that behavior sounds OK. I thi
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-HasComments: Yes

Reply via email to