Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2625/3/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 610: all_rows_returned > Ok, I don't feel strongly about it either way. all_rows_returned is clear. Done http://gerrit.cloudera.org:8080/#/c/2625/3/www/queries.tmpl File www/queries.tmpl: Line 79: in_flight_queries > Can you rename this to something like #waiting_queries or does this need to The name here needs to match the json endpoint, and we had discussed leaving the in_flight_queries the same to not affect CM, which relies on it. We could always just expose another endpoint called 'waiting_queries', and maybe eventually remove 'in_flight_queries' after getting CM updated. That would mean adding additional endpoints for any more functionality like this we want (eg. the 'waiting in admission queue' JIRA that's similar to this one), which seems a little messier than just keeping all active queries in a single endpoint and filtering. I don't think he template engine we use has support for comments that don't end up in the html. We could probably achieve something like that by doing '{{#comment}}', which would just disappear when the rendering happens since there wouldn't be a variable in the json matching the comment to replace the tag with, but that's a bit hack-y. I'm not sure what you're going for here, though - does the next line '{{?waiting}}', which is what actually does the filtering, not show what you want? -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
