Tim Armstrong has posted comments on this change. Change subject: IMPALA-3350: Add some missing StringVal.is_null checks ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2786/1/be/src/exprs/aggregate-functions.cc File be/src/exprs/aggregate-functions.cc: Line 280: if (UNLIKELY(src.is_null)) return DoubleVal::null(); > A counter argument to my point could be that we should check for Init() fai I think it's probably best to keep the null check to be safe. I doubt the predictable branch makes a difference when there is so much else going on around it. This would also go away if we switch to storing the avg inline in the tuple (which is probably a bigger perf problem than the null check). -- To view, visit http://gerrit.cloudera.org:8080/2786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
