Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-3350: Add some missing StringVal.is_null checks ......................................................................
IMPALA-3350: Add some missing StringVal.is_null checks Impala has a hardcoded limit of 1GB in size for StringVal. If the length of the string exceeds 1GB, Impala will simply mark the StringVal as NULL (i.e. is_null = true). It's important that string functions or built-in UDFs check this field before accessing the pointer or Impala may end up doing null pointer access, leading to crashes. Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2 --- M be/src/exprs/string-functions.cc M be/src/exprs/timestamp-functions.cc M be/src/exprs/udf-builtins.cc M be/src/exprs/utility-functions.cc M be/src/runtime/string-search.h M be/src/udf/udf.cc M testdata/workloads/functional-query/queries/QueryTest/alloc-fail-init.test M testdata/workloads/functional-query/queries/QueryTest/large_strings.test 8 files changed, 82 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/2786/3 -- To view, visit http://gerrit.cloudera.org:8080/2786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
