Dan Hecht has posted comments on this change. Change subject: IMPALA-3350: Add some missing StringVal.is_null checks ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2786/3/be/src/udf/udf.cc File be/src/udf/udf.cc: Line 459: if (UNLIKELY((unsigned)len > StringVal::MAX_LENGTH)) { maybe we should make StringVal::MAX_LENGTH unsigned so that comparisons will always be unsigned. there are other places that have this bug. -- To view, visit http://gerrit.cloudera.org:8080/2786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
