Michael Ho has posted comments on this change. Change subject: IMPALA-3350: Add some missing StringVal.is_null checks ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2786/2/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: Line 551: strs == NUL > when can this happen? Converted to DCHECK instead. Line 757: locate_substring > while here, could you rename to LocateSubstring() Done -- To view, visit http://gerrit.cloudera.org:8080/2786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
