Michael Ho has posted comments on this change. Change subject: IMPALA-3350: Add some missing StringVal.is_null checks ......................................................................
Patch Set 3: This patch has been scaled back to not handle initialization failure (due to malloc() returning NULL) for various built-in UDA. The proper fix for the UDA problem requires fixing various operators (e.g. analytic eval node, PAGG node etc) and comprehensive testing is also needed. Given malloc() returning NULL should be rare in 64-bit address space, that second problem will be addressed in a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/2786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
