Michael Ho has posted comments on this change. Change subject: IMPALA-3350: Add some missing StringVal.is_null checks ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2786/2/be/src/exprs/aggregate-functions.cc File be/src/exprs/aggregate-functions.cc: Line 248: if (UNLIKELY(src.is_null || dst->is_null)) return; > Can you explain why we need the dst->is_null check here? That should be an The short answer is that malloc() can return NULL. Please see my previous replies to Tim for the long answer. -- To view, visit http://gerrit.cloudera.org:8080/2786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
