Dan Hecht has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/2625/8/tests/custom_cluster/test_json_endpoints.py File tests/custom_cluster/test_json_endpoints.py: Line 51: test_webui isn't this test_json? in any case, why not just use a pre-existing table? Line 54: client.fetch("select * from test", op_handle) how does this work? isn't this executing another query (and what's table "test"?) Line 63: self.check_in_flight_query(impalad, True) this will likely be flaky in case the python gets delayed for too long. Line 65: self.check_in_flight_query(impalad, False) this can also be flaky if the impalad process is delayed. perhaps we shouldn't bother with the idle timeout. -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
